From: Lars Hansen [larsh@soem.dk]
Sent: Monday 07 November 2005 8:00 pm
To: Francis J. Wright
Subject: Emacs ls-lisp.el and w32-symlinks.el

Attachments: w32-symlinks.patch; ls-lisp.Francis-Wright.patch;
w32-symlinks.patched.el; ls-lisp.Francis-Wright.patched.el

Hi!

I have made some bugfixes/updates to w32-symlinks.el:

1. Use `w32-symlinks-operate-on-target' as handler for `file-regular-p'; it is supposed to operate on the target.
2. Special handler for `file-symlink-p'; it is supposed to return the link string, not just t.
3. Special handler for `file-attributes' that updates file-modes.
4. Special handler for `directory-files-and-attributes'. No previous handler.

The updated file and the diff is attached.

Because of these changes, special symlink handling in ls-lisp.el is no longer needed. Therefore I have removed the stub `ls-lisp-parse-symlinks' and the calls of it from ls-lisp.el, and in w32-symlinks.el, I have renamed `ls-lisp-parse-symlinks' to `w32-symlinks-parse-symlinks'. The updated file and the diff is attached.

I have tested my changes with Emacs 21 on Windows XP and on Debian GNU/Linux.

I intend to make the same changes to the version of ls-lisp.el in Emacs on CVS, so I hope that you will use the updates to w32-symlinks.el and ls-lisp.el on your web page http://centaur.maths.qmw.ac.uk/Emacs/. In that way w32-symlinks.el will work with Emacs 21 as well as the coming Emacs 22.

Regards, Lars Hansen

- - -

The updates I mailed to you are based on the versions of ls-lisp.el and w32-symlink.el on your website.

Lars